Horton

Re: Alpha4 release blockers (was Re: wrapping up this CommitFest)

Andres Freund <andres@anarazel.de>

View thread
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter_e@gmx.net>, pgsql-hackers@postgresql.org
Date: 2011-03-05T17:55:41Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Further refine patch for commenting operator implementation functions.

  2. Fix citext's upgrade-from-unpackaged script to set its collation correctly.

  3. Mark operator implementation functions as such in their comments.

  4. Add KNNGIST support to contrib/btree_gist.

  5. Fix plpython breakage detected on certain Fedora machines on buildfarm.

On Saturday 05 March 2011 18:43:31 Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > I have a WIP patch fixing one of the two issues.
> > 
> > Several places in selfuncs.c didn't setup collations. That lead for
> > example to errors during patternsel.
> 
> Hmm.  I have to say that this seems like quite the wrong way to go.
> If everyplace in the system that could be calling a collation-sensitive
> function has to be modified like this, we'll be fighting bugs of
> omission till h*ll freezes over.  Why aren't we just setting
> finfo.fn_collation to DEFAULT_COLLATION_OID by default, or maybe better
> letting places that inspect it take zero as meaning default collation?
> Call sites should only need to call fmgr_info_collation() if they have
> an explicit non-default collation to pass in.
I wondered the same. On the other hand it makes errors like the one during 
index build way much harder to catch...

Andres