Horton

Re: SSI bug?

Dan Ports <drkp@csail.mit.edu>

View thread
From: Dan Ports <drkp@csail.mit.edu>
To: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
Cc: Kevin.Grittner@wicourts.gov, pgsql-hackers@postgresql.org
Date: 2011-02-17T19:45:22Z
Lists: pgsql-hackers 
On Wed, Feb 16, 2011 at 10:13:35PM +0000, YAMAMOTO Takashi wrote:
> i got the following SEGV when runnning vacuum on a table.
> (the line numbers in predicate.c is different as i have local modifications.)
> oldlocktag.myTarget was NULL.
> it seems that TransferPredicateLocksToNewTarget sometimes use stack garbage
> for newpredlocktag.myTarget.  vacuum on the table succeeded with the attached
> patch.  the latter part of the patch was necessary to avoid targetList
> corruption, which later seems to make DeleteChildTargetLocks loop inifinitely.

Oops. Those are both definitely bugs (and my fault). Your patch looks
correct. Thanks for catching that!

Dan

-- 
Dan R. K. Ports              MIT CSAIL                http://drkp.net/