Re: updated patch for foreach stmt
Stephen Frost <sfrost@snowman.net>
From: Stephen Frost <sfrost@snowman.net>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Takahiro Itagaki <itagaki.takahiro@gmail.com>
Date: 2011-02-08T21:00:05Z
Lists: pgsql-hackers
Attachments
- plpgsql_foreach_2011020802.patch (text/x-diff) patch
* Robert Haas (robertmhaas@gmail.com) wrote:
> Amen to that!
Hopefully it helped. :)
> I think the syntax Tom suggested before was FOREACH thingy IN ARRAY
> arr rather than just FOREACH thingy IN arr. That's probably a good
> idea, because it gives us an escape hatch against needing to invent
> yet another variant of this syntax - the word immediately following IN
> can be known with confidence to be intended as a keyword rather than
> as part of the expression.
Alright, alright, *I* don't care that much, though I do feel it's a bit
excessive. Updated patch against HEAD attached.
commit a5d32fa41fbbbd9ace465f62be714366990061d4
Author: Stephen Frost <sfrost@snowman.net>
Date: Tue Feb 8 15:57:40 2011 -0500
PL/PgSQL FOREACH - Add ARRAY keyword
Add ARRAY as required after IN when using FOREACH, to
future-proof against later kinds of FOREACH commands.
Thanks,
Stephen