Re: review: FDW API

花田茂 <hanada@metrosystems.co.jp>

From: Shigeru HANADA <hanada@metrosystems.co.jp>

To: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>

Cc: Robert Haas <robertmhaas@gmail.com>, Jan Urbański <wulczer@wulczer.org>, Postgres - Hackers <pgsql-hackers@postgresql.org>

Date: 2011-02-08T11:07:09Z

Lists: pgsql-hackers

Attachments

avoid_catalog_lookup.patch (application/octet-stream) patch
20110208-foreign_scan.patch.gz (application/octet-stream) patch

On Mon, 07 Feb 2011 09:37:37 +0100
Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> wrote:

> On 07.02.2011 08:00, Shigeru HANADA wrote:
> > Sorry for late, attached are revised version of FDW API patches which
> > reflect Heikki's comments except removing catalog lookup via
> > IsForeignTable().  ISTM that the point is avoiding catalog lookup
> > during planning, but I have not found when we can set "foreign table
> > flag" without catalog lookup during RelOptInfo generation.
> 
> In get_relation_info(), you do the catalog lookup anyway and have the 
> Relation object at hand. Add a flag to RelOptInfo indicating if it's a 
> foreign table or not, and set that in get_relation_info().

Thanks a lot.

Attached is a revised version of foreign_scan patch.  This still
requires fdw_handler patch which was attached to the orginal post.

Avoid_catalog_lookup.patch is attached for review purpose.
This patch includes changes for this fix.

Regards,
--
Shigeru Hanada