Thread

1. Varlena and binary

   Radosław Smogura <mail@smogura.eu> — 2011-02-06T21:20:41Z

   Hi,
   
   I'm sending small patch for textsend. It reduces unnecessary copies, and 
   memory usage for duplication of varlena data. May you look?
   
   Kind regards,
   Radosław Smogura
   

2. Re: Varlena and binary

   Tom Lane <tgl@sss.pgh.pa.us> — 2011-02-07T16:12:07Z

   =?utf-8?q?Rados=C5=82aw_Smogura?= <mail@smogura.eu> writes:
   > I'm sending small patch for textsend. It reduces unnecessary copies, and 
   > memory usage for duplication of varlena data. May you look?
   
   This code will break the day that text and bytea don't have the same
   internal representation, which seems likely to be soon.  Barring some
   compelling evidence of a major performance improvement obtainable this
   way, I don't think we want this patch.
   
   			regards, tom lane
   
   

3. Re: Varlena and binary

   Radosław Smogura <rsmogura@softperience.eu> — 2011-02-07T21:57:39Z

   Just from curious may I ask in which direction this will go, and how this will 
   affect performance of text and binary format?
   
   Actually I started to make smaller improvements, and I think about one big to 
   encode text (when client and server encoding are different) directly to 
   StringInfo, without intermediate buffer.
   
   Thanks in advice
   Radek
   
   Tom Lane <tgl@sss.pgh.pa.us> Monday 07 February 2011 17:12:07
   > =?utf-8?q?Rados=C5=82aw_Smogura?= <mail@smogura.eu> writes:
   > > I'm sending small patch for textsend. It reduces unnecessary copies, and
   > > memory usage for duplication of varlena data. May you look?
   > 
   > This code will break the day that text and bytea don't have the same
   > internal representation, which seems likely to be soon.  Barring some
   > compelling evidence of a major performance improvement obtainable this
   > way, I don't think we want this patch.
   > 
   > 			regards, tom lane
   
   

4. Re: Varlena and binary

   Robert Haas <robertmhaas@gmail.com> — 2011-02-08T02:28:05Z

   On Mon, Feb 7, 2011 at 11:12 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
   > =?utf-8?q?Rados=C5=82aw_Smogura?= <mail@smogura.eu> writes:
   >> I'm sending small patch for textsend. It reduces unnecessary copies, and
   >> memory usage for duplication of varlena data. May you look?
   >
   > This code will break the day that text and bytea don't have the same
   > internal representation, which seems likely to be soon.
   
   Oh, really?
   
   -- 
   Robert Haas
   EnterpriseDB: http://www.enterprisedb.com
   The Enterprise PostgreSQL Company