Horton

Re: ALTER TYPE 2: skip already-provable no-work rewrites

Noah Misch <noah@leadboat.com>

View thread
From: Noah Misch <noah@leadboat.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org
Date: 2011-01-27T19:48:35Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Change ALTER TABLE SET WITHOUT OIDS to rewrite the whole table to physically

Attachments

On Wed, Jan 26, 2011 at 07:31:40AM -0500, Robert Haas wrote:
> I'd also suggest that this big if-block you changed to a case
> statement could just as well stay as an if-block.  There are only
> three cases, and we want to avoid rearranging things more than
> necessary.  It complicates both review and back-patching to no good
> end.

Okay.  I've also left out the large reindent in ATRewriteTable for now.  Easy to
re-add it later if desired.

> I think you should collect up what's left of ALTER TABLE 0 and the
> stuff on this thread, rebase it, and submit it as a single patch on
> this thread that applies directly against the master branch.  We may
> decide to split it back up again in some other way, but I think the
> current division isn't actually buying us much.

Done as attached.  This preserves compatibility with our current handling of
composite type dependencies.  The rest you've seen before.

Thanks,
nm