Re: new compiler warnings

Bruce Momjian <bruce@momjian.us>

From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>, pgsql-hackers@postgresql.org
Date: 2011-01-27T01:16:53Z
Lists: pgsql-hackers
Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > I can remove this warning by casting the pointer to (void *), rather
> > than (const void *) because that is what the prototype uses on my system
> > uses (libz.so.1.1.4):
> 
> > 	ZEXTERN int ZEXPORT    gzwrite OF((gzFile file,
> > 	                   const voidp buf, unsigned len));
> 
> BTW, I don't understand why that fixes it for you either.  As you can
> see, gzwrite *is* declared with const.  The reason why you're getting a
> warning is that zconf.h #define's const as nothing unless it thinks
> you're on an ANSI compiler (and the difference between 1.1.4 and 1.2.3
> is mostly that the former's test for ANSI-ness is brain dead).  But if
> you're compiling that #define then const or lack of it should mean
> nothing to you.

Let's wait and see if anyone else complains; I have adjusted things here.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +