Re: Error code for "terminating connection due to conflict with recovery"

Tatsuo Ishii <ishii@postgresql.org>

From: Tatsuo Ishii <ishii@postgresql.org>
To: robertmhaas@gmail.com
Cc: pgsql-hackers@postgresql.org
Date: 2011-01-13T07:13:09Z
Lists: pgsql-hackers

Attachments

>>> That doesn't sound right to me.  I'd have thought something in class 40.
>>
>> What about:
>>
>> 40004 CONFLICT WITH RECOVERY conflict_with_recovery
> 
> We should respect the following convention, from errcodes.h:
> 
>  * The convention is that new error codes defined by PostgreSQL in a
>  * class defined by the standard have a subclass value that begins
>  * with 'P'. In addition, error codes defined by PostgreSQL clients
>  * (such as ecpg) have a class value that begins with 'Y'.
> 
> And don't forget there are three places where the new error code would
> need to be added.
> 
> Otherwise, +1.

Ok. Here is the patch for this. I use 40P02, instead of 40004.
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese: http://www.sraoss.co.jp