Re: Add support for logging the current role

Stephen Frost <sfrost@snowman.net>

From: Stephen Frost <sfrost@snowman.net>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: Robert Haas <robertmhaas@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2011-01-12T17:25:11Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Add support for an application_name parameter, which is displayed in
- 8217cfbd9918 9.0.0 cited
Make CSV column ordering a bit more logical.
- 230e8962f3a4 8.3.0 cited
Extend the format of CSV logs to include the additional information supplied
- 3bf66d6f1c3a 8.3.0 cited
Add virtual transaction IDs to CSVLOG output, so that messages coming from
- 77c166ba6cf6 8.3.0 cited
Provide for logfiles in machine readable CSV format. In consequence, rename
- fd801f4faa8e 8.3.0 cited

* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> What you have just committed puts a syscache lookup into the elog output
> path.  Quite aside from the likely performance hit, this will
> malfunction badly in any case where we're trying to log from an aborted
> transaction.

Attached is my (admittedly horrible) attempt to add some comments to
elog.c regarding this issue.  Reviewing this, I'm not sure the
performance concern is really an issue (given that the user could choose
to enable it or not), but clearly the other issue is a concern.

Thanks,

	Stephen

commit 4dcf23e007967892557b7b113a9229cb9fc4575d
Author: Stephen Frost <sfrost@snowman.net>
Date:   Wed Jan 12 12:22:16 2011 -0500

    Improve comments at the top of elog.c
    
    Add in some comments about how certain usually available backend
    systems may be unavailable or which won't function properly in
    elog.c due to the current transaction being in a failed state.