Horton

Re: Large C files

Bruce Momjian <bruce@momjian.us>

View thread
From: Bruce Momjian <bruce@momjian.us>
To: Peter Geoghegan <peter@2ndquadrant.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Simon Riggs <simon@2ndquadrant.com>, Peter Eisentraut <peter_e@gmx.net>, PostgreSQL-development <pgsql-hackers@postgresql.org>, Jan Urbański <wulczer@wulczer.org>
Date: 2011-09-07T00:18:05Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix bug introduced by pgrminclude where the tablespace version name was

Peter Geoghegan wrote:
> On 7 September 2011 00:13, Peter Geoghegan <peter@2ndquadrant.com> wrote:
> > * Within TUs, we unshadow a previously shadowed variable, so we link
> > to a global variable rather than one local to the original/other new
> > file. Unlikely to be a problem. Here's what I get when I compile
> > xlog.c in the usual way with the addition of the -Wshadow flag:
> 
> I hit send too soon. Of course, this isn't going to matter in the case
> I described because an extern declaration of int foo cannot appear in
> the same TU as a static declaration of int foo - it won't compile. I
> hastily gave that as an example of a general phenomenon that can occur
> when performing this splitting process. An actually valid example of
> same would be if someone refactored functions a bit as part of this
> process to make things more modular, and now referenced a global
> variable rather than a local one as part of that process. This is
> quite possible, because namespace pollution is a big problem with
> heavyweight C files - Just look at how much output that -Wshadow flag
> gives when used on xlog.c.

I am confused how moving a function from one C file to another could
cause breakage?

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +