Re: getting carriage return character in vacuumo
Bruce Momjian <bruce@momjian.us>
From: Bruce Momjian <bruce@momjian.us>
To: Martijn van Oosterhout <kleptog@svana.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Muhammad Usama <m.usama@gmail.com>, pgsql-hackers@postgresql.org
Date: 2011-09-06T21:23:20Z
Lists: pgsql-hackers
Martijn van Oosterhout wrote: -- Start of PGP signed section. > On Fri, Apr 08, 2011 at 02:10:56PM -0400, Tom Lane wrote: > > Muhammad Usama <m.usama@gmail.com> writes: > > > While using the vacuumlo utility I encountered a redundant carriage > > > return(\r') character in the output. It is required in any scenario? If not, > > > please find attached a tiny patch which will get rid of that extra '\r' > > > character. > > > > I think the idea there is to overwrite successive progress messages > > on the same line. It's maybe not going to work in all environments, > > though, so perhaps we should reconsider that bit of cuteness. > > One could hinge it on batch or non-batch mode, the default being > determined by whether it's running in a terminal or not. pg_upgrade also uses this \r status update trick unconfitionally. Should we fix these? -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be true. +