Horton

Re: Large C files

Bruce Momjian <bruce@momjian.us>

View thread
From: Bruce Momjian <bruce@momjian.us>
To: Peter Eisentraut <peter_e@gmx.net>
Cc: PostgreSQL-development <pgsql-hackers@postgreSQL.org>
Date: 2011-09-06T14:05:32Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix bug introduced by pgrminclude where the tablespace version name was

Peter Eisentraut wrote:
> On l?r, 2011-09-03 at 19:18 -0400, Bruce Momjian wrote:
> > FYI, here are all the C files with over 6k lines:
> > 
> > -  45133 ./interfaces/ecpg/preproc/preproc.c
> > -  33651 ./backend/parser/gram.c
> > -  17551 ./backend/parser/scan.c
> >    14209 ./bin/pg_dump/pg_dump.c
> >    10590 ./backend/access/transam/xlog.c
> >     9764 ./backend/commands/tablecmds.c
> >     8681 ./backend/utils/misc/guc.c
> > -   7667 ./bin/psql/psqlscan.c
> >     7213 ./backend/utils/adt/ruleutils.c
> >     6814 ./backend/utils/adt/selfuncs.c
> >     6176 ./backend/utils/adt/numeric.c
> >     6030 ./pl/plpgsql/src/pl_exec.c
> > 
> > I have dash-marked the files that are computer-generated.  It seems
> > pg_dump.c and xlog.c should be split into smaller C files.
> 
> I was thinking about splitting up plpython.c, but it's not even on that
> list. ;-)

For me, the test is when I feel, "Yuck, I am in that massive file
again".

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +