Re: Re: [COMMITTERS] pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge

Bruce Momjian <bruce@momjian.us>

From: Bruce Momjian <bruce@momjian.us>

To: Jeremy Drake <pgsql@jdrake.com>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, Alvaro Herrera <alvherre@commandprompt.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>

Date: 2011-09-05T13:45:09Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Remove unnecessary #include references, per pgrminclude script.
- 6416a82a62db 9.2.0 cited
Remove "fmgr.h" include in cube contrib --- caused crash on a Gentoo
- d5321842528d 9.2.0 cited
Allow more include files to be compiled in their own by adding missing
- 4bd7333b1478 9.2.0 cited
Add support for #elif to pgrminclude.
- d010391ac8f7 9.2.0 cited

Jeremy Drake wrote:
> On Sun, 4 Sep 2011, Tom Lane wrote:
> 
> > What I would suggest is to see whether a more recent x86 version shows
> > the problem or not.  If not, let's just write it off as an already-fixed
> > compiler bug.
> 
> I have installed the most recent version in the home directory of a
> purpose-made user on that machine.
> 
> configure:3252: icc --version >&5
> icc (ICC) 12.0.5 20110719
> Copyright (C) 1985-2011 Intel Corporation.  All rights reserved.
> 
> I did
> git checkout 6416a82a62db4e66b2edb0fa8fc83a580c3f1931
> to get a revision I knew was right in the broken range for mongoose.
> 
> Apparently they deprecated one of my compiler flags: -xN (N is for
> Nocona), seems they renamed it to -xSSE2.  Since this is a one-off run, I
> ignored that warning.
> 
> The result is no crash in the cube test.
> 
> I think tomorrow I'll try to get the 9.0 compiler set up on a clean VM,
> and if the issue duplicates there, I can see about setting up SSH access
> if anyone is still interested in investigating this further.

What would we investigate except a compiler bug?

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +