Re: Re: patch review : Add ability to constrain backend temporary file space
Tatsuo Ishii <ishii@postgresql.org>
From: Tatsuo Ishii <ishii@postgresql.org>
To: tgl@sss.pgh.pa.us
Cc: ishii@postgresql.org, cedric.villemain.debian@gmail.com, mark.kirkwood@catalyst.net.nz, josh@agliodbs.com, robertmhaas@gmail.com, pgsql-hackers@postgresql.org
Date: 2011-07-17T21:53:29Z
Lists: pgsql-hackers
>> ereport(ERROR,
>> (errcode(ERRCODE_QUERY_CANCELED),
>> errmsg("aborting due to exceeding temp file limit, current usage %dkB, requested size %dkB, thus it will exceed temp file limit %dkB",
>> (int)(temporary_files_size/1024),
>> amount,
>> temp_file_limit)));
>
> The thing is that unless "amount" is really large, you're just going to
> have two numbers that are very close to each other. I think this is
> just useless complication, because "amount" is almost always going to
> be 8kB or less.
Oops. My bad. I should have divide "amount" by 1024. Now I understand
your point.
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese: http://www.sraoss.co.jp