Thread

Re: Avoid index rebuilds for no-rewrite ALTER TABLE ALTER TYPE

Noah Misch <noah@2ndquadrant.com> — 2011-07-06T18:50:39Z

On Wed, Jul 06, 2011 at 09:55:01AM -0400, Robert Haas wrote:
> On Thu, Jun 30, 2011 at 1:02 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> > On first blush, that looks a whole lot cleaner. ?I'll try to find some
> > time for a more detailed review soon.
> 
> This seems not to compile for me:
> 
> gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith
> -Wdeclaration-after-statement -Wendif-labels -Wformat-security
> -fno-strict-aliasing -fwrapv -g -Werror -I../../../src/include
> -I/opt/local/include  -c -o index.o index.c -MMD -MP -MF
> .deps/index.Po
> index.c:692: error: conflicting types for ?index_create?
> ../../../src/include/catalog/index.h:53: error: previous declaration
> of ?index_create? was here
> cc1: warnings being treated as errors
> index.c: In function ?index_create?:
> index.c:821: warning: passing argument 5 of ?heap_create? makes
> integer from pointer without a cast
> index.c:821: warning: passing argument 6 of ?heap_create? makes
> pointer from integer without a cast
> index.c:821: error: too few arguments to function ?heap_create?

Drat; fixed in this version.  My local branches contain a large test battery
that I filter out of the diff before posting.  This time, that filter also
removed an essential part of the patch.

Thanks,
nm