Re: Identifying no-op length coercions
Noah Misch <noah@leadboat.com>
From: Noah Misch <noah@leadboat.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgresql.org, Alexey Klyukin <alexk@commandprompt.com>
Date: 2011-06-19T03:06:25Z
Lists: pgsql-hackers
On Sat, Jun 18, 2011 at 10:57:13PM -0400, Robert Haas wrote:
> On Sat, Jun 11, 2011 at 5:13 PM, Noah Misch <noah@leadboat.com> wrote:
> > Sounds good. ?Updated patch attached, incorporating your ideas. ?Before applying
> > it, run this command to update the uninvolved pg_proc.h DATA entries:
> > ?perl -pi -e 's/PGUID(\s+\d+){4}/$& 0/' src/include/catalog/pg_proc.h
>
> This doesn't quite apply any more. I think the pgindent run broke it slightly.
Hmm, I just get two one-line offsets when applying it to current master. Note
that you need to run the perl invocation before applying the patch. Could you
provide full output of your `patch' invocation, along with any reject files?
Thanks,
nm