Re: Patch by request at pgcon

Stephen Frost <sfrost@snowman.net>

From: Stephen Frost <sfrost@snowman.net>
To: Greg Stark <stark@mit.edu>
Cc: "<pgsql-hackers@postgresql.org>" <pgsql-hackers@postgresql.org>
Date: 2011-05-19T17:53:59Z
Lists: pgsql-hackers
* Greg Stark (stark@mit.edu) wrote:
> Adding such a feature would be pretty trivial, attached is a patch.

Quick code-only review: sortedAttrs is a horrible var name for what it
is.  More like 'sortbyName' would make more sense, at least to me.
Also, no regression test..? :)  The interface looks alright to me,
though I wonder for a moment if this might be a \set option.  Are there
other things which could be sorted differently based on such an
option..?  If not, then perhaps another char for \dt is right.

	Thanks,

		Stephen