Re: pg_upgrade automatic testing

On Wed, Apr 27, 2011 at 09:32:16PM +0300, Peter Eisentraut wrote:
> On tor, 2011-04-07 at 23:02 +0300, Peter Eisentraut wrote:
> > Seeing that 9.1-to-9.1 pg_upgrade has apparently been broken for months,
> > it would probably be good to have some kind of automatic testing for it.
> > Attached is something I hacked together that at least exposes the
> > current problems, easily available by typing "make check" and waiting.
> > It does not yet fully implement the full testing procedure in the
> > TESTING file, in particular the diffing of the dumps (well, because you
> > can't get there yet).
> > 
> > Is that something that people are interested in refining?
> > 
> > (I think it would even be possible under this setup to create special
> > regression test cases that are only run under the pg_upgrade test run,
> > to exercise particularly tricky upgrade cases.)
> 
> Now that this is bound to be fixed, here is an updated script that runs
> the entire test procedure including diffing the dumps at the end.

Enthusiastic +1 for this concept.  There's at least one rough edge: it fails if
you have another postmaster running on port 5432.

Thanks,
nm