Horton

Re: Typed table DDL loose ends

Noah Misch <noah@leadboat.com>

View thread
From: Noah Misch <noah@leadboat.com>
To: Peter Eisentraut <peter_e@gmx.net>
Cc: pgsql-hackers@postgresql.org
Date: 2011-04-20T14:53:34Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Prevent a rowtype from being included in itself.

Attachments

On Mon, Apr 18, 2011 at 10:44:53PM +0300, Peter Eisentraut wrote:
> On Sat, 2011-04-09 at 21:57 -0400, Noah Misch wrote:
> > * Inheriting from a typed table blocks further type DDL
> >   CREATE TYPE t AS (x int);
> >   CREATE TABLE parent OF t;
> >   CREATE TABLE child () INHERITS (parent);
> >   ALTER TYPE t ADD ATTRIBUTE y int CASCADE;
> >   -- ERROR:  column must be added to child tables too
> > We ought to just set INH_YES on the downstream command in ATTypedTableRecursion.
> > If we get to that point, the user did choose ALTER TYPE CASCADE; it seems fair
> > to assume he'd want inheritance recursion rather than a later error.
> 
> Agreed.

Patch attached for that.  Apart from a comment, a test case and a doc update, it
turned out to be a one-liner.