Re: pg_upgrade bug found!

Bruce Momjian wrote:
> Robert Haas wrote:
> > >> Well, that won't work, because VACUUM can't be executed in a transaction
> > >> block or function.
> > >
> > > Good point.
> > >
> > > The only bright part of this is that missing clog will throw an error so
> > > we are not returning incorrect data, and hopefully people will report
> > > problems to us when it happens.
> > >
> > > Ideally I would like to get this patch and correction code out into the
> > > field in case more people run into this problem. ?I know some will, I
> > > just don't know how many.
> > 
> > ISTM we need to force a minor release once we are sure this has been
> > corrected.  We had also probably put out an announcement warning
> > people that have already used pg_upgrade of possible data corruption.
> > I'm not sure exactly what the language around that should be, but this
> > does seem pretty bad.
> 
> Yep, "pretty bad" it is.

The bug exists because I did not realize that the toast relfrozenxid is
tracked independently of the heap, until the IRC report diagnosis.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +