Re: Comments on SQL/Med objects

花田茂 <hanada@metrosystems.co.jp>

From: Shigeru HANADA <hanada@metrosystems.co.jp>

To: Robert Haas <robertmhaas@gmail.com>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, Guillaume Lelarge <guillaume@lelarge.info>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2011-04-01T13:40:50Z

Lists: pgsql-hackers

Attachments

20110401_merge_oid_funcs.patch (application/octet-stream) patch
20110401_pg_dump_support.patch (application/octet-stream) patch
20110401_psql_describe.patch (application/octet-stream) patch
20110401_psql_tab.patch (application/octet-stream) patch

On Thu, 31 Mar 2011 11:24:27 -0400
Robert Haas <robertmhaas@gmail.com> wrote:
> Attached.  Foreign tables are already OK, I believe; it's only foreign
> data wrappers and foreign servers that appear to need fixing.

The patch seems good for basic functionarity.  I've tested the patch
and noticed that get_foreign_data_wrapper_oid() is same as
GetForeignDataWrapperOidByName(), so they could be merged.  Also
GetForeignServerOidByName() could be merged.

I changed "foreign data wrapper" in message to "foreign-data wrapper"
for consistency, but it's revertable.

Please see merge_oid_funcs.patch which can be applied onto your patch.

I think some supports can be added for comments on SQL/MED objects.

  - pg_dump support for comment on fdw and server
  - psql describe commands (\dew+ and \des+)
  - psql TAB completion

Please see attached patches for each feature.

While testing pg_dump, I noticed that comment of extension's member
objects are not dumped by pg_dump.  Those comments should be dumped
after CREATE EXTENSION statement?

Regards,
--
Shigeru Hanada