Re: duplicate connection failure messages

Bruce Momjian <bruce@momjian.us>

View thread

From: Bruce Momjian <bruce@momjian.us>

To: Peter Eisentraut <peter_e@gmx.net>

Cc: Magnus Hagander <magnus@hagander.net>, pgsql-hackers@postgresql.org

Date: 2010-11-12T01:54:17Z

Lists: pgsql-hackers

Attachments

/pgpatches/libpq_ipv6 (text/x-diff) patch

Peter Eisentraut wrote:
> On tor, 2010-10-14 at 07:30 +0200, Magnus Hagander wrote:
> > And I agree it's not very friendly in this specific case - I
> > wonder if we should log it as "localhost (127.0.0.1) and "localhost
> > (::1)" (and similar for any other case that returns more than one
> > address).
> 
> That looks good.

I have developed the attached patch to report whether IPv4 or IPv6 are
being used.  I could not find the numeric value as alwasy populated, and
this seems clearer too:

	$ pql -h localhost test
	psql: could not connect to server: Connection refused
	        Is the server running on host "localhost" (IPv4) and accepting
	        TCP/IP connections on port 5432?

	$ psql -h 127.0.0.1 test
	psql: could not connect to server: Connection refused
	        Is the server running on host "127.0.0.1" (IPv4) and accepting
	        TCP/IP connections on port 5432?

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +