Re: [PATCH] V3: Idle in transaction cancellation
Andres Freund <andres@anarazel.de>
From: Andres Freund <andres@anarazel.de>
To: "Kevin Grittner" <Kevin.Grittner@wicourts.gov>
Cc: pgsql-hackers@postgresql.org
Date: 2010-11-02T21:36:19Z
Lists: pgsql-hackers
On Tuesday 02 November 2010 18:33:15 Kevin Grittner wrote: > Andres Freund <andres@anarazel.de> wrote: > > * You wont see an error if the next command after the IDLE in > > transaction is a COMMIT/ROLLBACK. I don*t see any sensible way > > around that. > Well, on a ROLLBACK I'm not sure it's a problem. On a COMMIT, > couldn't you call a function to check for it in CommitTransaction > and PrepareTransaction? Sure, throwing an error somewhere wouldnt be that hard. But at the moment a COMMIT is always successfull (and just reporting a ROLLBACK in a failed txn). Doesn't seem to be something to changed lightly. Does anybody have any idea why COMMIT is allowed there? Seems pretty strange to me. Andres