Re: Tab completion for view triggers in psql
David Fetter <david@fetter.org>
From: David Fetter <david@fetter.org>
To: Itagaki Takahiro <itagaki.takahiro@gmail.com>
Cc: PG Hackers <pgsql-hackers@postgresql.org>
Date: 2010-10-29T15:33:00Z
Lists: pgsql-hackers
Attachments
- psql_view_trigger_tab_completion_3.diff (text/plain) patch
On Tue, Oct 26, 2010 at 11:55:07AM +0900, Itagaki Takahiro wrote: > On Tue, Oct 26, 2010 at 11:34 AM, David Fetter <david@fetter.org> wrote: > >> Do we need to 'add' it? > > Possibly. My understanding is that it couldn't really replace it. > > Ah, I see. I was wrong. We can have modification privileges for > views even if they have no INSTEAD OF triggers. Right. > So, I think your original patch is the best solution. We could use > has_table_privilege() additionally, but we need to consider any > other places if we use it. For example, DROP privileges, etc. That seems like a matter for a separate patch. Looking this over, I found I'd created a query that can never get used, so please find enclosed the next version of the patch :) Cheers, David. -- David Fetter <david@fetter.org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david.fetter@gmail.com iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics Remember to vote! Consider donating to Postgres: http://www.postgresql.org/about/donate