Re: booleans in recovery.conf
Bruce Momjian <bruce@momjian.us>
From: Bruce Momjian <bruce@momjian.us>
To: Simon Riggs <simon@2ndQuadrant.com>
Cc: PostgreSQL-development <pgsql-hackers@postgreSQL.org>
Date: 2010-03-31T14:19:51Z
Lists: pgsql-hackers
Attachments
- /rtmp/diff (text/x-diff) patch
Simon Riggs wrote: > On Tue, 2010-03-23 at 19:43 -0400, Bruce Momjian wrote: > > Is there a reason that recovery.conf uses true/false, while > > postgresql.conf uses on/off? > > > > #recovery_target_inclusive = 'true' # 'true' or 'false' > > > > or are these settings more boolean for some reason? > > The code accepts any of on|off|true|false and uses the same code as the > postgresql.conf for parsing that. > > I've changed the standby_mode to on|off as per the docs. I left the > above parameter because true|false reads better. Agreed. I also applied the attached change so defaults are listed and example values only appear as comments in the file. This makes the file match postgresql.conf in style. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com