Re: [GENERAL] trouble with to_char('L')

Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp>

View thread

From: Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp>

To: Bruce Momjian <bruce@momjian.us>

Cc: Hiroshi Inoue <inoue@tpf.co.jp>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2010-03-18T03:34:20Z

Lists: pgsql-hackers, pgsql-general

Attachments

pg_locale_20100318.patch (application/octet-stream) patch

Bruce Momjian <bruce@momjian.us> wrote:

> Takahiro Itagaki wrote:
> > Since 9.0 has GetPlatformEncoding() for the purpose, we could simplify
> > db_encoding_strdup() with the function. Like this:
> 
> OK, I don't have any Win32 people testing this patch so if we want this
> fixed for 9.0 someone is going to have to test my patch to see that it
> works.  Can you make the adjustments suggested above to my patch and
> test it to see that it works so we can apply it for 9.0?

Here is a full patch that can be applied cleanly to HEAD.
Can anyone test it on Windows?

I'm not sure why temporary changes of lc_ctype was required in the
original patch. The codes are not included in my patch, but please
notice me it is still needed.

Regards,
---
Takahiro Itagaki
NTT Open Source Software Center