Re: pq_setkeepalives* functions

Bruce Momjian wrote:
> Tom Lane wrote:
> > Bruce Momjian <bruce@momjian.us> writes:
> > > Tom Lane wrote:
> > >> This makes the function *not* like the other two, rather than
> > >> improving consistency.
> > 
> > > Well, it makes it like some of the existing functions, but not like
> > > others.  This applied patch fixes them all.
> > 
> > This is making things worse, not better.  You have just changed the
> > behavior, and not in a good way.  Formerly these were no-ops on
> > a unix socket connection, and now they can throw errors.
> 
> OK, reverted.  Let me study the entire file.

Clarification, both changes reverted.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  PG East:  http://www.enterprisedb.com/community/nav-pg-east-2010.do