Horton
Menu

Re: lock mode for ControlFileLock which pg_start_backup uses

Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp>

View thread
From: Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2010-03-10T02:09:40Z
Lists: pgsql-hackers 
Fujii Masao <masao.fujii@gmail.com> wrote:

> Currently pg_start_backup() accesses the shared ControlFile
> by using ControlFileLock with LW_EXCLUSIVE lock mode. But
> since that access is read-only operation, LW_SHARED should
> be chosen instead of LW_EXCLUSIVE.
> 
> The attached patch changes the lock mode which pg_start_backup()
> uses. Is it worth applying this patch?

Thanks, applied.

Regards,
---
Takahiro Itagaki
NTT Open Source Software Center