Re: ecpg tests broken by pgindent run
Bruce Momjian <bruce@momjian.us>
From: Bruce Momjian <bruce@momjian.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Boszormenyi Zoltan <zb@cybertec.at>, Tom Lane <tgl@sss.pgh.pa.us>, Michael Meskes <meskes@postgresql.org>, pgsql-hackers@postgresql.org
Date: 2010-02-26T18:00:22Z
Lists: pgsql-hackers
Andrew Dunstan wrote: > > > Bruce Momjian wrote: > >>>> > >>>> > >>> Don't look further, interfaces/ecpg/include/sqlda.h has changed > >>> by the pgindent run. > >>> > >> Yea, it is that, and sqltypes.h and one other file I am trying to find > >> now. > >> > > > > I have reverted changes to three include files who's output appears in > > the regression tests. I asssume this is new 9.0 behavior because I > > didn't have this issue before. I also updated the pgindent script to > > prevent these from being changed in the future. > > > > > > Should not the instructions include doing a full set of regression tests > to ensure that nothing breaks? The new installcheck-world target should > help there. Wow, I didn't know that was available. I have updated the pgindent README. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com PG East: http://www.enterprisedb.com/community/nav-pg-east-2010.do + If your life is a hard drive, Christ can be your backup. +