Re: ecpg tests broken by pgindent run

Bruce Momjian <bruce@momjian.us>

From: Bruce Momjian <bruce@momjian.us>
To: Boszormenyi Zoltan <zb@cybertec.at>, Tom Lane <tgl@sss.pgh.pa.us>, Michael Meskes <meskes@postgresql.org>
Cc: pgsql-hackers@postgresql.org
Date: 2010-02-26T17:09:23Z
Lists: pgsql-hackers

Attachments

Bruce Momjian wrote:
> Boszormenyi Zoltan wrote:
> > > but if I look at the CVS history for
> > > /cvsroot/pgsql/src/interfaces/ecpg/test/expected/compat_informix-sqlda.c
> > > I see the last change was January 6, not from pgindent.
> > >
> > > My only guess is that there was some boilerplate code in the ecpg C
> > > files or outside /test which changed when ran pgindent.
> > >
> > > I am researching now.
> > >   
> > 
> > Don't look further, interfaces/ecpg/include/sqlda.h has changed
> > by the pgindent run.
> 
> Yea, it is that, and sqltypes.h and one other file I am trying to find
> now.

I have reverted changes to three include files who's output appears in
the regression tests.   I asssume this is new 9.0 behavior because I
didn't have this issue before.   I also updated the pgindent script to
prevent these from being changed in the future.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com
  PG East:  http://www.enterprisedb.com/community/nav-pg-east-2010.do
  + If your life is a hard drive, Christ can be your backup. +