Re: psql tab completion for DO blocks

Bruce Momjian <bruce@momjian.us>

From: Bruce Momjian <bruce@momjian.us>

To: Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp>

Cc: Robert Haas <robertmhaas@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Peter Eisentraut <peter_e@gmx.net>, David Fetter <david@fetter.org>, PG Hackers <pgsql-hackers@postgresql.org>

Date: 2010-02-11T00:21:25Z

Lists: pgsql-hackers

Takahiro Itagaki wrote:
> 
> Bruce Momjian <bruce@momjian.us> wrote:
> 
> > Where are we on this patch?  We should at least implement the completion
> > for 'LANGUAGE' in 'DO', and use the existing pg_language query for
> > completion.  I am attaching a patch that does exactly this.
> 
> I don't think we need the patch except adding DO to the top-level sql_commands.
> 
> Syntax of DO command is:
>     DO code [ LANGUAGE lang_name ]
> We need 'code' before LANGUAGE, but the patch completes "DO" to "DO LANGUAGE".
> It will be just a syntax error.
> 
> Also, we've already had a completion after LANGUAGE (see words_after_create),
> so we don't need an additional Query_for_list_of_languages after LANGUAGE.

Ah, I see.  I had not checked the patch against the actual syntax; shame
on me.

> BTW, I'm working on psql tab-completion adjustment for new syntax in 9.0.
> I'll send it soon.

OK, thanks.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +