Re: TRUNCATE+COPY optimization and --jobs=1 in pg_restore
Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp>
From: Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org
Date: 2010-02-10T04:11:08Z
Lists: pgsql-hackers
Attachments
- restore-wal-skip_20100210.patch (application/octet-stream) patch
Tom Lane <tgl@sss.pgh.pa.us> wrote: > Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp> writes: > > We have an optimization to bulkload date in pg_restore, but the code > > only works in parallel restore (--jobs >= 2). Why don't we do the > > same optimization in the serial restore (--jobs = 1) ? > > The code is only trying to substitute for something you can't have > in parallel restore, ie --single-transaction. Yeah, the comment says so. But it does not necessarily mean that we cannot optimize the copy also in non-single-transaction restore. The attached patch improve the judgment condition, I'll add it to the next commit-fest. Regards, --- Takahiro Itagaki NTT Open Source Software Center