Horton
Menu

Thread

  1. pgsql: Remove tabs in SGML.

    momjian@postgresql.org — 2010-01-26T14:21:29Z

    Log Message:
-----------
Remove tabs in SGML.

Modified Files:
--------------
    pgsql/doc/src/sgml:
        ecpg.sgml (r1.94 -> r1.95)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/ecpg.sgml?r1=1.94&r2=1.95)

  2. Re: [COMMITTERS] pgsql: Remove tabs in SGML.

    David Fetter <david@fetter.org> — 2010-01-26T18:20:26Z

    On Tue, Jan 26, 2010 at 02:21:29PM +0000, Bruce Momjian wrote:
> Log Message:
> -----------
> Remove tabs in SGML.

Can we see about making a commit hook for CVS that disallows \t in
SGML files?  The process in git is pretty simple.

Cheers,
David.
-- 
David Fetter <david@fetter.org> http://fetter.org/
Phone: +1 415 235 3778  AIM: dfetter666  Yahoo!: dfetter
Skype: davidfetter      XMPP: david.fetter@gmail.com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

  3. Re: [COMMITTERS] pgsql: Remove tabs in SGML.

    Peter Eisentraut <peter_e@gmx.net> — 2010-01-27T14:52:00Z

    On tis, 2010-01-26 at 10:20 -0800, David Fetter wrote:
> On Tue, Jan 26, 2010 at 02:21:29PM +0000, Bruce Momjian wrote:
> > Log Message:
> > -----------
> > Remove tabs in SGML.
> 
> Can we see about making a commit hook for CVS that disallows \t in
> SGML files?  The process in git is pretty simple.

Better write a check in the makefile.

  4. Re: [COMMITTERS] pgsql: Remove tabs in SGML.

    David Fetter <david@fetter.org> — 2010-01-27T17:04:06Z

    On Wed, Jan 27, 2010 at 04:52:00PM +0200, Peter Eisentraut wrote:
> On tis, 2010-01-26 at 10:20 -0800, David Fetter wrote:
> > On Tue, Jan 26, 2010 at 02:21:29PM +0000, Bruce Momjian wrote:
> > > Log Message:
> > > -----------
> > > Remove tabs in SGML.
> > 
> > Can we see about making a commit hook for CVS that disallows \t in
> > SGML files?  The process in git is pretty simple.
> 
> Better write a check in the makefile.

That assumes that everyone will always actually run the appropriate
make before committing, which I wouldn't assume, especially for a
"trivial" patch that's going out when someone is pressed for time.
Checking in an unavoidable place seems much more foolproof.

Cheers,
David.
-- 
David Fetter <david@fetter.org> http://fetter.org/
Phone: +1 415 235 3778  AIM: dfetter666  Yahoo!: dfetter
Skype: davidfetter      XMPP: david.fetter@gmail.com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

  5. Re: [COMMITTERS] pgsql: Remove tabs in SGML.

    Tom Lane <tgl@sss.pgh.pa.us> — 2010-01-27T17:27:08Z

    David Fetter <david@fetter.org> writes:
> On Wed, Jan 27, 2010 at 04:52:00PM +0200, Peter Eisentraut wrote:
>> Better write a check in the makefile.

> That assumes that everyone will always actually run the appropriate
> make before committing, which I wouldn't assume, especially for a
> "trivial" patch that's going out when someone is pressed for time.
> Checking in an unavoidable place seems much more foolproof.

The rule against tabs in SGML files is only a bit of anal retentivity
anyway.  I don't think that enforcing it is worth special hacks that
we do not use anywhere else.

			regards, tom lane

  6. Re: [COMMITTERS] pgsql: Remove tabs in SGML.

    David Fetter <david@fetter.org> — 2010-01-27T17:30:03Z

    On Wed, Jan 27, 2010 at 12:27:08PM -0500, Tom Lane wrote:
> David Fetter <david@fetter.org> writes:
> > On Wed, Jan 27, 2010 at 04:52:00PM +0200, Peter Eisentraut wrote:
> >> Better write a check in the makefile.
> 
> > That assumes that everyone will always actually run the
> > appropriate make before committing, which I wouldn't assume,
> > especially for a "trivial" patch that's going out when someone is
> > pressed for time.  Checking in an unavoidable place seems much
> > more foolproof.
> 
> The rule against tabs in SGML files is only a bit of anal
> retentivity anyway.  I don't think that enforcing it is worth
> special hacks that we do not use anywhere else.

Good point.  What other pre-commit hooks do we need?

Cheers,
David.
-- 
David Fetter <david@fetter.org> http://fetter.org/
Phone: +1 415 235 3778  AIM: dfetter666  Yahoo!: dfetter
Skype: davidfetter      XMPP: david.fetter@gmail.com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

  7. Re: [COMMITTERS] pgsql: Remove tabs in SGML.

    Joshua D. Drake <jd@commandprompt.com> — 2010-01-27T17:33:31Z

    On Wed, 2010-01-27 at 12:27 -0500, Tom Lane wrote:
> David Fetter <david@fetter.org> writes:
> > On Wed, Jan 27, 2010 at 04:52:00PM +0200, Peter Eisentraut wrote:
> >> Better write a check in the makefile.
> 
> > That assumes that everyone will always actually run the appropriate
> > make before committing, which I wouldn't assume, especially for a
> > "trivial" patch that's going out when someone is pressed for time.
> > Checking in an unavoidable place seems much more foolproof.
> 
> The rule against tabs in SGML files is only a bit of anal retentivity
> anyway. 

I disagree. SGML suffers the same as code if you are using tabs.


Joshua D. Drake


-- 
PostgreSQL.org Major Contributor
Command Prompt, Inc: http://www.commandprompt.com/ - 503.667.4564
Consulting, Training, Support, Custom Development, Engineering
Respect is earned, not gained through arbitrary and repetitive use or Mr. or Sir.

  8. Re: [COMMITTERS] pgsql: Remove tabs in SGML.

    Tom Lane <tgl@sss.pgh.pa.us> — 2010-01-27T17:41:28Z

    David Fetter <david@fetter.org> writes:
> On Wed, Jan 27, 2010 at 12:27:08PM -0500, Tom Lane wrote:
>> The rule against tabs in SGML files is only a bit of anal
>> retentivity anyway.  I don't think that enforcing it is worth
>> special hacks that we do not use anywhere else.

> Good point.  What other pre-commit hooks do we need?

Hm, aren't you one of the main cheerleaders for moving to git?
Why would you want us to be installing any additional CVS dependencies
right now?  Adding commit hooks would just create another must-do-
before-moving task.  If we actually desperately *needed* some, maybe
it'd be worth it, but I can't see that this kind of thing is worth it.

			regards, tom lane

  9. Re: [COMMITTERS] pgsql: Remove tabs in SGML.

    David Fetter <david@fetter.org> — 2010-01-27T17:42:48Z

    On Wed, Jan 27, 2010 at 12:41:28PM -0500, Tom Lane wrote:
> David Fetter <david@fetter.org> writes:
> > On Wed, Jan 27, 2010 at 12:27:08PM -0500, Tom Lane wrote:
> >> The rule against tabs in SGML files is only a bit of anal
> >> retentivity anyway.  I don't think that enforcing it is worth
> >> special hacks that we do not use anywhere else.
> 
> > Good point.  What other pre-commit hooks do we need?
> 
> Hm, aren't you one of the main cheerleaders for moving to git?

Yes.

> Why would you want us to be installing any additional CVS dependencies
> right now?  Adding commit hooks would just create another must-do-
> before-moving task.

Right now is not the time.

> If we actually desperately *needed* some, maybe it'd be worth it,
> but I can't see that this kind of thing is worth it.

Post-git-move would be a better time to revisit this.

Cheers,
David.
-- 
David Fetter <david@fetter.org> http://fetter.org/
Phone: +1 415 235 3778  AIM: dfetter666  Yahoo!: dfetter
Skype: davidfetter      XMPP: david.fetter@gmail.com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

  10. Re: [COMMITTERS] pgsql: Remove tabs in SGML.

    Peter Eisentraut <peter_e@gmx.net> — 2010-01-27T21:23:12Z

    On ons, 2010-01-27 at 09:04 -0800, David Fetter wrote:
> On Wed, Jan 27, 2010 at 04:52:00PM +0200, Peter Eisentraut wrote:
> > On tis, 2010-01-26 at 10:20 -0800, David Fetter wrote:
> > > On Tue, Jan 26, 2010 at 02:21:29PM +0000, Bruce Momjian wrote:
> > > > Log Message:
> > > > -----------
> > > > Remove tabs in SGML.
> > > 
> > > Can we see about making a commit hook for CVS that disallows \t in
> > > SGML files?  The process in git is pretty simple.
> > 
> > Better write a check in the makefile.
> 
> That assumes that everyone will always actually run the appropriate
> make before committing, which I wouldn't assume, especially for a
> "trivial" patch that's going out when someone is pressed for time.

Even if you are pressed for time, you are supposed to check your patch.
And even then, we have the community and automated build services to
pick up after you.

> Checking in an unavoidable place seems much more foolproof.

I'm going to put in an advance vote here against any kind of
code-checking commit hook.  Because they live in the repository
metadata, they can only be seen and changed by the system
administrators, they do not travel with the source code, and they are
not under version control themselves.  The source code and the scripts
and tests to manage it should be self-consistent and not dependent on
external containers.

  11. Re: [COMMITTERS] pgsql: Remove tabs in SGML.

    Bruce Momjian <bruce@momjian.us> — 2010-02-05T14:52:17Z

    Peter Eisentraut wrote:
> On tis, 2010-01-26 at 10:20 -0800, David Fetter wrote:
> > On Tue, Jan 26, 2010 at 02:21:29PM +0000, Bruce Momjian wrote:
> > > Log Message:
> > > -----------
> > > Remove tabs in SGML.
> > 
> > Can we see about making a commit hook for CVS that disallows \t in
> > SGML files?  The process in git is pretty simple.
> 
> Better write a check in the makefile.

Done, and attached.  The rule is more shell script than makefile, but I
am not sure how else to do it.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

  12. Re: [COMMITTERS] pgsql: Remove tabs in SGML.

    Alvaro Herrera <alvherre@commandprompt.com> — 2010-02-05T19:04:22Z

    Bruce Momjian wrote:
> Peter Eisentraut wrote:
> > On tis, 2010-01-26 at 10:20 -0800, David Fetter wrote:
> > > On Tue, Jan 26, 2010 at 02:21:29PM +0000, Bruce Momjian wrote:
> > > > Log Message:
> > > > -----------
> > > > Remove tabs in SGML.
> > > 
> > > Can we see about making a commit hook for CVS that disallows \t in
> > > SGML files?  The process in git is pretty simple.
> > 
> > Better write a check in the makefile.
> 
> Done, and attached.  The rule is more shell script than makefile, but I
> am not sure how else to do it.

Maybe have the check-tabs rule as a dependency of the "check", "html"
and/or "draft" rules?

> + check-tabs:
> + 	( ! grep '	' $(wildcard $(srcdir)/*.sgml $(srcdir)/ref/*.sgml) ) || (echo "Tabs appear in SGML files";  exit 1)



-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

  13. Re: [COMMITTERS] pgsql: Remove tabs in SGML.

    Bruce Momjian <bruce@momjian.us> — 2010-02-05T19:09:08Z

    Alvaro Herrera wrote:
> Bruce Momjian wrote:
> > Peter Eisentraut wrote:
> > > On tis, 2010-01-26 at 10:20 -0800, David Fetter wrote:
> > > > On Tue, Jan 26, 2010 at 02:21:29PM +0000, Bruce Momjian wrote:
> > > > > Log Message:
> > > > > -----------
> > > > > Remove tabs in SGML.
> > > > 
> > > > Can we see about making a commit hook for CVS that disallows \t in
> > > > SGML files?  The process in git is pretty simple.
> > > 
> > > Better write a check in the makefile.
> > 
> > Done, and attached.  The rule is more shell script than makefile, but I
> > am not sure how else to do it.
> 
> Maybe have the check-tabs rule as a dependency of the "check", "html"
> and/or "draft" rules?
> 
> > + check-tabs:
> > + 	( ! grep '	' $(wildcard $(srcdir)/*.sgml $(srcdir)/ref/*.sgml) ) || (echo "Tabs appear in SGML files";  exit 1)

Uh, I didn't think people wanted to actually have any tab testing in
their automatically.  Do they?

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

  14. Re: [COMMITTERS] pgsql: Remove tabs in SGML.

    Alvaro Herrera <alvherre@commandprompt.com> — 2010-02-05T19:13:11Z

    Bruce Momjian wrote:
> Alvaro Herrera wrote:

> > Maybe have the check-tabs rule as a dependency of the "check", "html"
> > and/or "draft" rules?
> > 
> > > + check-tabs:
> > > + 	( ! grep '	' $(wildcard $(srcdir)/*.sgml $(srcdir)/ref/*.sgml) ) || (echo "Tabs appear in SGML files";  exit 1)
> 
> Uh, I didn't think people wanted to actually have any tab testing in
> their automatically.  Do they?

IMO that's the point of the whole exercise.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

  15. Re: [COMMITTERS] pgsql: Remove tabs in SGML.

    Bruce Momjian <bruce@momjian.us> — 2010-02-05T19:32:13Z

    Alvaro Herrera wrote:
> Bruce Momjian wrote:
> > Alvaro Herrera wrote:
> 
> > > Maybe have the check-tabs rule as a dependency of the "check", "html"
> > > and/or "draft" rules?
> > > 
> > > > + check-tabs:
> > > > + 	( ! grep '	' $(wildcard $(srcdir)/*.sgml $(srcdir)/ref/*.sgml) ) || (echo "Tabs appear in SGML files";  exit 1)
> > 
> > Uh, I didn't think people wanted to actually have any tab testing in
> > their automatically.  Do they?
> 
> IMO that's the point of the whole exercise.

OK, done with attached patch, now done as part of 'gmake check'.  If
people want it as part of the build process, please let me know.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +