Re: Re: [COMMITTERS] pgsql: Write a WAL record whenever we perform an operation without
Tatsuo Ishii <ishii@postgresql.org>
From: Tatsuo Ishii <ishii@postgresql.org>
To: heikki.linnakangas@enterprisedb.com
Cc: masao.fujii@gmail.com, simon@2ndquadrant.com, pgsql-hackers@postgresql.org
Date: 2010-02-03T10:19:19Z
Lists: pgsql-hackers
> Fujii Masao wrote: > > On Mon, Feb 1, 2010 at 7:40 PM, Heikki Linnakangas > > <heikki.linnakangas@enterprisedb.com> wrote: > >> So you get those messages when the table is *not* a temporary table. I > >> can see now what Fujii was trying to say. His patch seems Ok, though > >> perhaps it would be better to move the responsibility of calling > >> XLogReportUnloggedStatement() to the callers of heap_sync(). When I put > >> it in heap_sync(), I didn't take into account that it's sometimes called > >> just to flush buffers from buffer cache, not to fsync() non-WAL-logged > >> operations. > > > > As you said, I moved the responsibility of calling XLogReportUnloggedStatement() > > to the callers of heap_sync(). Here is the patch. > > Committed. The use_wal parameter to end_heap_rewrite() was not > necessary, that information is already in RewriteState, so I took that out. Are we going to bump up frontend/backend protocol version 3.0 to 3.x or some such? -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese: http://www.sraoss.co.jp