Horton
Menu

Re: ECPGset_var

Alvaro Herrera <alvherre@commandprompt.com>

View thread
From: Alvaro Herrera <alvherre@commandprompt.com>
To: Boszormenyi Zoltan <zb@cybertec.at>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Michael Meskes <meskes@postgresql.org>, PostgreSQL Hacker <pgsql-hackers@postgresql.org>
Date: 2010-01-26T18:32:45Z
Lists: pgsql-hackers 
Boszormenyi Zoltan wrote:

> Thanks for analyzing it, patch is attached. I downloaded
> and installed ICC, so I could reproduce the difference.

Why not have a single function that does both things in a single call?
It doesn't look like there's any place that calls the function with only
one value for "insert" ...

I happened to notice this misleading comment:

        char temp[20]; /* this should be sufficient unless you have 8 byte integers */

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.