Re: plpgsql: open for execute - add USING clause

Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp>

From: Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp>
To: Pavel Stehule <pavel.stehule@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2010-01-14T01:34:21Z
Lists: pgsql-hackers
Pavel Stehule <pavel.stehule@gmail.com> wrote:

> ok, I accept all comments.
> revised version are attached.

Good. This patch is ready to commit. I'll do it soon if no objections.

BTW, I found inconsistent parameter dumps in the codes. Some of them
add '$', but others does not. Are they intentional? Or, should we
adjust them to use one of the formats?

[pl_funcs.c]
dump_dynexecute()
dump_raise()
			printf("    parameter %d: ", i++);
dump_dynfors()
dump_open()
dump_return_query()
			printf("    parameter $%d: ", i++);


Regards,
---
Takahiro Itagaki
NTT Open Source Software Center