Horton
Menu

Thread

  1. Use of PG_VERSION

    Bruce Momjian <bruce@momjian.us> — 2010-01-06T21:27:06Z

    Is there a reason tablespace.c::set_short_version() uses PG_VERSION, and
not the simpler PG_MAJORVERSION?  initdb.c::get_short_version() does the
same thing.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

  2. Re: Use of PG_VERSION

    Tom Lane <tgl@sss.pgh.pa.us> — 2010-01-06T22:08:27Z

    Bruce Momjian <bruce@momjian.us> writes:
> Is there a reason tablespace.c::set_short_version() uses PG_VERSION, and
> not the simpler PG_MAJORVERSION?  initdb.c::get_short_version() does the
> same thing.

Probably that code predates the addition of the separate PG_MAJORVERSION
#define.  +1 for simplifying.  The change I just had to make in
backend/catalog/Makefile reinforces the thought that MAJORVERSION is
what we should be using in everyplace related to this type of check.

			regards, tom lane

  3. Re: Use of PG_VERSION

    Bruce Momjian <bruce@momjian.us> — 2010-01-06T23:22:57Z

    Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > Is there a reason tablespace.c::set_short_version() uses PG_VERSION, and
> > not the simpler PG_MAJORVERSION?  initdb.c::get_short_version() does the
> > same thing.
> 
> Probably that code predates the addition of the separate PG_MAJORVERSION
> #define.  +1 for simplifying.  The change I just had to make in
> backend/catalog/Makefile reinforces the thought that MAJORVERSION is
> what we should be using in everyplace related to this type of check.

Agreed.  Fixed the attached, applied patch.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +