Re: Verifying variable names in pgbench

Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp>

View thread

From: Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp>

To: pgsql-hackers@postgresql.org

Cc: Robert Haas <robertmhaas@gmail.com>

Date: 2010-01-05T03:00:51Z

Lists: pgsql-hackers

Attachments

pgbench_verify_varname_20100105.patch (application/octet-stream) patch

Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp> wrote:

> We can remove the complexity if we give up showing the command (arg0)
> in error messages. Shall we remove it? Simplified patch attached.

Here is the proposal for the arg0 issue.
I added "context" argument to putVariable(). The context is a command
name for \setXXX commands, 'option' for -D option, or 'startup' for
internal assignment in startup.

Regards,
---
Takahiro Itagaki
NTT Open Source Software Center