Re: Fw: patch for pg_ctl.c to add windows service start-type

Quan Zongliang <quanzongliang@gmail.com>

From: Quan Zongliang <quanzongliang@gmail.com>

To: Magnus Hagander <magnus@hagander.net>

Cc: Alvaro Herrera <alvherre@commandprompt.com>, David Fetter <david@fetter.org>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2010-08-22T14:03:32Z

Lists: pgsql-hackers

Attachments

pg_ctl.diff (text/plain) patch

Sure, I agree.
New patch attached. How about this?

On Fri, 20 Aug 2010 11:21:18 +0200
Magnus Hagander <magnus@hagander.net> wrote:

> On Fri, Aug 20, 2010 at 01:01, Quan Zongliang <quanzongliang@gmail.com> wrote:
> > Because Windows's CreateService has serial start-type:
> > SERVICE_AUTO_START
> > SERVICE_BOOT_START
> > SERVICE_DEMAND_START
> > SERVICE_DISABLED
> > SERVICE_SYSTEM_START
> >
> > Although all of them are not useful for pg service.
> > I think it is better to use enum.
> 
> I don't see us ever using anything other than auto or demand. The
> others aren't for "regular services", except for "disabled". And
> adding a disabled service makes no sense :-) So I'm with Alvaro, I
> think it's a good idea to simplify that.
> 
> 
> -- 
>  Magnus Hagander
>  Me: http://www.hagander.net/
>  Work: http://www.redpill-linpro.com/


-- 
Quan Zongliang <quanzongliang@gmail.com>