Re: gSoC - ADD MERGE COMMAND - code patch submission

David Fetter <david@fetter.org>

From: David Fetter <david@fetter.org>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: Robert Haas <robertmhaas@gmail.com>, Andres Freund <andres@anarazel.de>, Boxuan Zhai <bxzhai2010@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, "heikki.linnakangas@enterprisedb.com" <heikki.linnakangas@enterprisedb.com>

Date: 2010-07-10T17:39:02Z

Lists: pgsql-hackers

Attachments

merge3.diff (text/plain) patch

On Sat, Jul 10, 2010 at 01:18:49PM -0400, Tom Lane wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
> > Though, if the worst problem with this patch is the formatting, we're doing *quite* well.
> 
> Well, the worst problem with it is that it hasn't touched the
> interesting part, ie, what happens at execution time.  I haven't
> seen a design for that, which means it's impossible to evaluate
> whether the code that is here is of any use.  We might need some
> other representation entirely.
> 
> BTW, Fetter's version of the patch seems to be lacking any gram.y
> changes, but surely those exist already?

Oops.

Fixed that now in attached patch.

Cheers,
David.
-- 
David Fetter <david@fetter.org> http://fetter.org/
Phone: +1 415 235 3778  AIM: dfetter666  Yahoo!: dfetter
Skype: davidfetter      XMPP: david.fetter@gmail.com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate