Horton
Menu

Re: 9.0beta2 - server crash when using HS + SR

Bruce Momjian <bruce@momjian.us>

View thread
From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Fujii Masao <masao.fujii@gmail.com>, Greg Smith <greg@2ndquadrant.com>, Rafael Martinez <r.m.guerrero@usit.uio.no>, Robert Haas <robertmhaas@gmail.com>, pgsql-hackers@postgresql.org
Date: 2010-06-30T23:41:53Z
Lists: pgsql-hackers

Attachments

Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > The attached patch shows the hint only during recovery.
> 
> BTW, it would be easier and more consistent with the rest of the code to
> look at InRecovery, instead of messing around with the function
> signature.  And the usual way to emit a hint conditionally is
> 
> 	(InRecovery ? errhint(...) : 0)
> 
> rather than duplicate a lot of surrounding code.

Thanks for the "hints".   I was thinking there was a way to use ? : for
the hint, but couldn't find an example.  I see examples now.  Updated
patch attached.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + None of us is going to be here forever. +