Horton
Menu

Re: Allow wal_keep_segments to keep all segments

Bruce Momjian <bruce@momjian.us>

View thread
From: Bruce Momjian <bruce@momjian.us>
To: Alvaro Herrera <alvherre@commandprompt.com>
Cc: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>, Simon Riggs <simon@2ndquadrant.com>, Robert Haas <robertmhaas@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Fujii Masao <masao.fujii@gmail.com>, Josh Berkus <josh@agliodbs.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2010-06-03T19:35:35Z
Lists: pgsql-hackers 
Alvaro Herrera wrote:
> Excerpts from Bruce Momjian's message of jue jun 03 08:36:28 -0400 2010:
> 
> > Using this only temporarily is mentioned in the doc patch.  Do I need
> > more?
> 
> Yeah, it's far too easy to miss.  Besides, I think the wording you used
> is ambiguous -- it can be read as "the server will temporarily keep all
> segments if you set it to -1", which is not the same thing at all.  If
> you can't add a 20-point-font red blinking warning with a pink dancing
> elephant in a tutu, maybe it's best to not offer the dangerous setting
> in the first place.

Well, it seems enough people don't want this features that I am not
going to add it.  If we decide we want it later, we can add it.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + None of us is going to be here forever. +