Re: is_absolute_path incorrect on Windows
Bruce Momjian <bruce@momjian.us>
From: Bruce Momjian <bruce@momjian.us>
To: Giles Lean <giles.lean@pobox.com>
Cc: Greg Stark <gsstark@mit.edu>, Magnus Hagander <magnus@hagander.net>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2010-06-01T03:02:21Z
Lists: pgsql-hackers
Giles Lean wrote: > > Greg Stark <gsstark@mit.edu> wrote: > > > /* NOTE: these two functions aren't complementary under windows, > > * be sure to use the right one */ > > > > /* Check path always means the same thing regardless of cwd */ > > is_absolute_path() > > /* Check that path is under cwd */ > > is_relative_path() > > Um ... isn't that second function name pretty misleading, if > what you want is what the comment above it says? > > Assuming the comment is what you want (presumably, else you'd > just negate a test of is_absolute_path()) then my suggestions > for (IMHO :-) clearer names would be is_subdir_path() if you > still want "path" in the name, or just is_subdir() if the > meaning will be clear enough from context. is_relative_to_cwd()? -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + None of us is going to be here forever. +