Re: is_absolute_path incorrect on Windows

Giles Lean <giles.lean@pobox.com>

From: Giles Lean <giles.lean@pobox.com>
To: Greg Stark <gsstark@mit.edu>
Cc: Magnus Hagander <magnus@hagander.net>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2010-06-01T02:58:28Z
Lists: pgsql-hackers
Greg Stark <gsstark@mit.edu> wrote:

> /* NOTE: these two functions aren't complementary under windows,
>  * be sure to use the right one */
> 
> /* Check path always means the same thing regardless of cwd */
> is_absolute_path()
> /* Check that path is under cwd */
> is_relative_path()

Um ... isn't that second function name pretty misleading, if
what you want is what the comment above it says?

Assuming the comment is what you want (presumably, else you'd
just negate a test of is_absolute_path()) then my suggestions
for (IMHO :-) clearer names would be is_subdir_path() if you
still want "path" in the name, or just is_subdir() if the
meaning will be clear enough from context.

Giles