Re: Patch for PKST timezone

Aftab Hussain <aftab.se@gmail.com> wrote:

> Please accept attached patch for the following problem.

This patch has not been replied, but I can reproduce the error with:
=# SET timezone = 'Asia/Karachi';
=# SELECT timeofday()::timestamptz;
ERROR:  invalid input syntax for type timestamp with time zone: "Tue May 11 13:26:53.264293 2010 PKST"

Should we add PKST timezone? Also, I found a list of timezones[1]
and we don't have 36 tznames in the list. Should we also need them?

    ACDT, AEDT, AWDT
    BIT
    CBT, CDBT, CIST
    HMT
    PKST, PMT
    R*T and R*DT series,
    WCDT, WCT, WIB, WITA, WKT

[1] http://www.world-time-zones.org/zones/

> aftab@aftab-laptop:/opt/dev/pgsql/install/dbserver/bin$
> aftab@aftab-laptop:/opt/dev/pgsql/install/dbserver/bin$ ./psql postgres
> psql (9.0beta1)
> Type "help" for help.
> 
> postgres=# SHOW timezone;
>    TimeZone
> --------------
>  Asia/Karachi
> (1 row)
> 
> postgres=#
> postgres=# CREATE TABLE test_table (c1 INT, c2 TIMESTAMP DEFAULT
> timeofday()::TIMESTAMP);
> CREATE TABLE
> postgres=# INSERT INTO test_table VALUES (1);
> ERROR:  invalid input syntax for type timestamp: "Fri Apr 30 15:36:43.906075
> 2010 PKST"
> postgres=#
> 
> And here is a little bit information about the system I am using.
> 
> aftab@aftab-laptop:/opt/dev/pgsql/install/dbserver/bin$  uname -a
> Linux aftab-laptop 2.6.31-20-generic #58-Ubuntu SMP Fri Mar 12 05:23:09 UTC
> 2010 i686 GNU/Linux
> aftab@aftab-laptop:/opt/dev/pgsql/install/dbserver/bin$
> aftab@aftab-laptop:/opt/dev/pgsql/install/dbserver/bin$ ./pg_config
> --version
> PostgreSQL 9.0beta1
> aftab@aftab-laptop:/opt/dev/pgsql/install/dbserver/bin$


Regards,
---
Takahiro Itagaki
NTT Open Source Software Center