Re: [GENERAL] trouble with to_char('L')
Bruce Momjian <bruce@momjian.us>
From: Bruce Momjian <bruce@momjian.us>
To: Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp>
Cc: Hiroshi Inoue <inoue@tpf.co.jp>, Magnus Hagander <magnus@hagander.net>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2010-04-24T23:03:28Z
Lists: pgsql-hackers, pgsql-general
Attachments
- /rtmp/diff (text/x-diff) patch
Takahiro Itagaki wrote: > > Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp> wrote: > > > Revised patch attached. Please test it. > > I applied this version of the patch. > Please check wheter the bug is fixed and any buildfarm failures. Great. I have merged in my C comments into the code with the attached patch so we remember why the code is setup as it is. One thing I am confused about is that, for Win32, our numeric/monetary handling sets lc_ctype to match numeric/monetary, while our time code in the same file uses that method _and_ uses wcsftime() to return the value in wide characters. So, why do we do both for time? Is there any value to that? Seems we should do the same for both numeric/monetary and time. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com