Re: Streaming replication and a disk full in primary
Alvaro Herrera <alvherre@commandprompt.com>
From: Alvaro Herrera <alvherre@commandprompt.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>, Fujii Masao <masao.fujii@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2010-04-15T14:39:24Z
Lists: pgsql-hackers
Robert Haas escribió: > In the department of minor nits, I also don't like the fact that the > GUC is called standby_keep_segments and the variable is called > StandbySegments. If we really have to capitalize them differently, we > should at least make it StandbyKeepSegments, but personally I think we > should use standby_keep_segments in both places so that it doesn't > take quite so many greps to find all the references. +1, using both names capitalized identically makes the code easier to navigate. -- Alvaro Herrera http://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc.