Re: uintptr_t for Datum

Bruce Momjian <bruce@momjian.us>

From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Magnus Hagander <magnus@hagander.net>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2009-12-31T17:43:44Z
Lists: pgsql-hackers

Attachments

Tom Lane wrote:
> Magnus Hagander <magnus@hagander.net> writes:
> > Attached patch is the part of the win64 patch that changes Datum to be
> > uintptr_t, and associated changes, with only very minor changes from
> > me. It also includes autoconf tests that I tricked Bruce into fixing
> > for me :-)
> 
> > Comments?
> 
> This is a joke no?  Where's the logic to provide a definition of
> intptr_t if the platform fails to?  The lack of attention to updating
> the comments about Datum doesn't give me a warm feeling either.
> 
> BTW, it looks like the patch is showing a manual change to
> pg_config.h.in.  Don't do that.  Run autoheader.

I wasn't aware autoheader existed.  Is that new or has it alwasy been
part of autoconf?

Attached is the diff for pg_config.h.in generated by autoheader.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +