Re: exec_execute_message crash

Tatsuo Ishii <ishii@postgresql.org>

From: Tatsuo Ishii <ishii@postgresql.org>
To: andrew@dunslane.net
Cc: pgsql-hackers@postgresql.org
Date: 2009-12-30T14:26:00Z
Lists: pgsql-hackers
> Tatsuo Ishii wrote:
> > ! 	if (!PortalIsValid(portal) || (PortalIsValid(portal) && portal->cleanup == NULL))
> >  
> >   
> 
> 
> Surely the second call to PortalIsValid() is redundant.
>       
>     if (( !PortalIsValid(portal)) || portal->cleanup == NULL)
> 
> should do it, no?

Oops. You are right.
--
Tatsuo Ishii
SRA OSS, Inc. Japan