Horton

Re: pgbench: new feature allowing to launch shell commands

Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp>

View thread View on postgr.es
From: Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Greg Smith <greg@2ndquadrant.com>, pgsql-hackers@postgresql.org
Date: 2009-12-09T06:12:32Z
Lists: pgsql-hackers 
Michael Paquier <michael.paquier@gmail.com> wrote:

> Please find attached the latest version of the patch,
> with the threading bug corrected and the documentation updated as well.

Why do you use BUFFER_SIZE-1 for snprintf?
   snprintf(commandShell, SHELL_COMMAND_SIZE-1, ...)
Trailing nulls are also included in the length, so
   snprintf(commandShell, SHELL_COMMAND_SIZE, ...)
would be ok. (removed -1)

Other parts look fine, except an empty tag <replaceable></> in the
documentation. Is it a typo?

Regards,
---
Takahiro Itagaki
NTT Open Source Software Center